Terminal session info on job side bar
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Problem to solve
- Job sidebar when the job script has not finished yet:
- Job sidebar when the job script has finished already, countdown active:
Further details
Assuming that this data comes from #js-job-details-vue specified endpoint. I imagine we can have in the response is a new key session which can look like the following:
"session": {
"terminal": {
"timeout": 18000 <-- Value in seconds
"started": "2018-08-09T12:41:30.647Z" <-- The latest session that the user created
}
}
The started date will be updated everytime the user opens the connection, so if the user closes the terminal and opens it again the latest date will be returned.
The reason I think we should nest it like session.termal is because in the future we might want to more feature to the session not just the terminal so we can easily seperate the information.
Now since the user can access the terminal when the job still hasn't finish (in running state) with the above information you should be able to know if the terminal, is pending, or you need to start showing the countdown, am I assuming right?
What does success look like, and how can we measure that?
(If no way to measure success, link to an issue that will implement a way to measure this)
Links / references
gitlab-ce#25990
https://gitlab.com/gitlab-org/gitlab-ce/issues/25990#note_93254119

