Ci `include` is not used in the root entry
The include
entry from Gitlab::Ci::Config::Entry::Root
doesn't seem to be used during the validation step because it is removed when the YAML is expanded. Execution trace:
- https://gitlab.com/gitlab-org/gitlab/-/blob/33a30ac369558476d77b92309b6c34613bc8752d/lib/gitlab/ci/config.rb#L25
- https://gitlab.com/gitlab-org/gitlab/-/blob/33a30ac369558476d77b92309b6c34613bc8752d/lib/gitlab/ci/config.rb#L68
- https://gitlab.com/gitlab-org/gitlab/-/blob/33a30ac369558476d77b92309b6c34613bc8752d/lib/gitlab/ci/config.rb#L81
- https://gitlab.com/gitlab-org/gitlab/-/blob/33a30ac369558476d77b92309b6c34613bc8752d/lib/gitlab/ci/config/external/processor.rb#L25
- https://gitlab.com/gitlab-org/gitlab/-/blob/33a30ac369558476d77b92309b6c34613bc8752d/lib/gitlab/ci/config/external/processor.rb#L47
- https://gitlab.com/gitlab-org/gitlab/-/blob/33a30ac369558476d77b92309b6c34613bc8752d/lib/gitlab/ci/config.rb#L28
At the 6th step we validate the include
entry, but it validates a nil
value because the config was removed from the hash at step 5.
Should we remove include
from the root entry config?
Edited by Marius Bobin