Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 35,803
    • Issues 35,803
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1,268
    • Merge Requests 1,268
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Issues
  • #237848

Closed
Open
Opened Aug 17, 2020 by Matthias Käppler@mkaeppler🔴Maintainer

Image scaling: Only allow JPG and PNG

Some image formats like SVGs represent an attack vector for image processing as they might embed malicious code, something we had problems with in the past: #219010 (closed)

Moreover, we haven't sufficiently tested image scaling with less popular image formats such as TIFF or ICO. PNGs and JPGs make up 99% of our current avatar data set, so this is a good and safe place start.

The simplest thing we can do currently is to outright filter those out.

For SVGs specifically, we already reject them from avatar uploads, so no further action needed here:

Screenshot_from_2020-08-20_13-51-13

Edited Aug 20, 2020 by Matthias Käppler
Assignee
Assign to
13.4
Milestone
13.4 (Past due)
Assign milestone
Time tracking
None
Due date
None
Reference: gitlab-org/gitlab#237848