Convert Mutations::Security::CiConfiguration to use actual GraphQL types instead of GraphQL::Types::JSON
About
This issue is to explore whether the Mutations::Security::CiConfiguration
mutation could be changed to use GraphQL types to describe the JSON.
Context
We discourage the use of GraphQL::Types::JSON
for GraphQL fields and instead encourage the schema to describe the structure of the JSON https://docs.gitlab.com/ee/development/api_graphql_styleguide.html#json.
A cop was added in !38125 (merged) to enforce this, however until !39406 (merged) the cop was only covering types and not mutations or resolvers.
Considerations
- Whether it makes sense within the domain to make this change
- Whether we can introduce a breaking change (MR !38406 (merged) was introduced in
13.3
so this is likely possible if done soon)
Edited by Luke Duncalfe