Make sure Projects::TransferService uses Sidekiq to move Pages
Part of &3980 (closed). Sentry example: https://sentry.gitlab.net/gitlab/gitlabcom/issues/1729301/?query=is%3Aunresolved%20%22gitlab%3A%3Apages%3A%3Asettings%3A%3ADiskAccessDenied%22
When a project is renamed it hits Projects::TransferService somewhere. This class has to rename the pages of the project, if any, because pages do not use hashed storage. That renaming touches NFS which we don't want to do from Puma (&3980 (closed)).
What
Remove the :async_pages_move_project_transfer
feature flag ...
Owners
- Team: ~"team::Scalability"
- Most appropriate slack channel to reach out to:
#g_scalability
- Best individual to reach out to: @reprazent
Expectations
What are we expecting to happen?
What might happen if this goes wrong?
What can we monitor to detect problems with this?
Beta groups/projects
If applicable, any groups/projects that are happy to have this feature turned on early. Some organizations may wish to test big changes they are interested in with a small subset of users ahead of time for example.
-
gitlab-org/gitlab
project -
gitlab-org
/gitlab-com
groups - ...
Roll Out Steps
-
Enable on staging -
Test on staging -
Ensure that documentation has been updated -
Enable on GitLab.com for individual groups/projects listed above and verify behaviour -
Coordinate a time to enable the flag with #production
and#g_delivery
on slack. -
Announce on the issue an estimated time this will be enabled on GitLab.com -
Enable on GitLab.com by running chatops command in #production
-
Cross post chatops slack command to #support_gitlab-com
(more guidance when this is necessary in the dev docs) and in your team channel -
Announce on the issue that the flag has been enabled -
Remove feature flag and add changelog entry -
After the flag removal is deployed, clean up the feature flag by running chatops command in #production
channel
Edited by Bob Van Landuyt