Refer to project delete instead of remove in the codebase
Problem to solve
In #221100 (closed) the phrase "delete" was changed to "remove" (in relation to projects) in the documentation to improve clarity and consistency. However, the code itself was not changed.
Proposal
Re-name "delete" as "remove" in relation to projects.
From the previous MR !38489 (merged), some code changes have already been found:
-
@splattael started a discussion: Nitpick: Do we also want to rename the method?
🤔 def delete_group_message(group)
-
@splattael started a discussion: Nitpick: Same here, do we also want to rename the method?
🤔 def delete_project_message(project)
-
@splattael started a discussion: Nitpick: Should we also rename this partial
app/views/projects/_delete.html.haml
?🤔 -
@splattael started a discussion: Non-blocking Out of scope: What about renaming the policy from
remove_project
todelete_project
?🤔 Even more out of scope: We also have:
enable :remove_project
enable :remove_fork_project
enable :remove_pages
rule { ~admin & owner & owner_cannot_destroy_project }.prevent :remove_project
Interestingly, we are using "destroy" (
owner_cannot_destroy_project
) and not delete additionally.😅 -
@splattael started a discussion: Nitpick: Should this
partialtemplate be calledee/app/views/dashboard/projects/deleted.html.haml
?🤔 -
@splattael started a discussion: Nitpick: Should we rename it to
ee/app/views/dashboard/_deleted_projects_tab.html.haml
?🤔 -
@splattael started a discussion: Nitpick: Same here, we could rename it to
ee/app/views/projects/_delete.html.haml
. WDYT?🤔