Improve UI on Settings>CI/CD>Variables>Edit
Problem to solve
The UI when editing a variable for CI/CD could use some improvement. The problem is that the delete button is right between the Cancel and Update Value buttons. Additionally when clicking Delete there is not a confirmation step. These two things lead to a situation where you could inadvertently and easily delete a value. The button should probably be separated from the others, or there should be a confirmation, or both.
While it's true Gitlab might not be the only place a variable is stored (i.e. a secret), it's still annoying when you can delete it so easily, and it could be time consuming to fix the mistake.
(anybody who might edit CI/CD variables)
- Delaney (Development Team Lead)
- Sasha (Software Developer)
- Devon (DevOps Engineer)
- Sidney (Systems Administrator)
- Rachel (Release Manager)
- Priyanka (Platform Engineer)
User experience goal
The user should not be able to easily delete a variable when they are intending to just edit it. People make mistakes, protect them from themselves a little bit.
Move the delete button to the left edge of the dialog, and add an "are you sure?" step (could be configurable even for people who are annoyed by the confirmation). Optionally, an Undo (i.e. in a banner) would be nice.
Permissions and Security
no changes to permissions
Availability & Testing
No impact to availability.