Migrate Bootstrap dropdown to GitLab UI GlDropdown in files importing app/assets/javascripts/vue_shared/components/dropdown/dropdown_button.vue
We need to replace the occurrences of dropdown_button
with GlDropdown
in the following files:
-
app/assets/javascripts/create_cluster/components/cluster_form_dropdown.vue
-
Using app/assets/javascripts/create_cluster/gke_cluster/components/gke_dropdown_mixin.js
: -
app/assets/javascripts/ide/components/nav_dropdown_button.vue
-
app/assets/javascripts/ide/components/file_templates/dropdown.vue
When we have migrated all the above files, we can simply delete the following file:
- app/assets/javascripts/vue_shared/components/dropdown/dropdown_button.vue
Instructions
-
Replace uses of data-toggle="dropdown"
with GitLab UI components<gl-dropdown>
,<gl-dropdown-divider>
,<gl-dropdown-header>
, and<gl-dropdown-item>
. -
Take before/after screenshots of each button in the file, and include them in the Merge Request description. -
Request review from a designer within your stage group. If you are outside of a stage group, ping a UX foundations member.
GlDropdown
documentation can be found here: https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-dropdown--default
Part of &4134
Edited by Mark Florian