[Feature flag] Rollout of personal_snippet_reference_filters

What

Remove the :personal_snippet_reference_filters feature flag ...

Owners

Current:

  • Team: groupknowledge
  • Most appropriate Slack channel to reach out to: #g_knowledge
  • Best individual to reach out to: @ikvikakk

Original:

  • Team: Create::Editor
  • Most appropriate slack channel to reach out to: #g_create_editor
  • Best individual to reach out to: @vij or @fran

Expectations

What are we expecting to happen?

  • References to resources added to PersonalSnippet comments and descriptions should be converted via the GFM/AbstractReferenceFilter to GitLab references (docs) on create/update and preview of changes.
    • Example of such a reference not converted (user FF not enabled) and converted (user FF enabled) in the comments of a personal snippet:
      image
  • Links to personal snippets themselves are resolved into $123 syntax, and the same syntax works to specify them in the first place.
    • N.B. This requires the FF be enabled site-wide; it doesn't work on a per-actor basis, as reference resolution happens without respect to the viewing user.
    • Example of it not working:
      image
    • Example of it working (shown on staging):
      image
      image

What might happen if this goes wrong?

References may not be generated correctly.

What can we monitor to detect problems with this?

Beta groups/projects/users

Roll Out Steps

  • Enable on staging
  • Test on staging
  • Ensure that documentation has been updated
  • Enable on GitLab.com by running chatops command in #production
  • Announce on the issue that the flag has been enabled
  • Remove feature flag and add changelog entry
  • After the flag removal is deployed, clean up the feature flag by running chatops command in #production channel
Edited by Asherah Connor