GraphQL 500 Internal Server Error : addAwardEmoji

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

Summary

GraphQL mutation result in 500 status

Steps to reproduce

Mutation contains null byte string, so using screenshot instead of pasting text.

mutation {
  awardEmojiAdd(input: { awardableId: "gid://gitlab/Issue/69506789", name: "\u0000", clientMutationId: "" }) {
    awardEmoji {
      description
    }
  }
}

Example Project

Docker image of 13.0.12-ce.0

What is the current bug behavior?

500 status code returned

What is the expected correct behavior?

200 status code returned

Relevant logs and/or screenshots

ArgumentError (string contains null byte):

app/services/award_emojis/add_service.rb:16:in `execute'

lib/gitlab/metrics/instrumentation.rb:161:in `block in execute'

lib/gitlab/metrics/method_call.rb:36:in `measure'

lib/gitlab/metrics/instrumentation.rb:161:in `execute'

app/graphql/mutations/award_emojis/add.rb:13:in `resolve'

lib/gitlab/graphql/generic_tracing.rb:40:in `with_labkit_tracing'

lib/gitlab/graphql/generic_tracing.rb:30:in `platform_trace'

lib/gitlab/graphql/generic_tracing.rb:40:in `with_labkit_tracing'

lib/gitlab/graphql/generic_tracing.rb:30:in `platform_trace'

lib/gitlab/graphql/generic_tracing.rb:40:in `with_labkit_tracing'

lib/gitlab/graphql/generic_tracing.rb:30:in `platform_trace'

app/graphql/gitlab_schema.rb:41:in `multiplex'

app/graphql/gitlab_schema.rb:48:in `execute'

app/controllers/graphql_controller.rb:65:in `execute_query'

app/controllers/graphql_controller.rb:30:in `execute'

app/controllers/application_controller.rb:496:in `set_current_admin'

lib/gitlab/session.rb:11:in `with_session'

app/controllers/application_controller.rb:487:in `set_session_storage'

lib/gitlab/i18n.rb:55:in `with_locale'

lib/gitlab/i18n.rb:61:in `with_user_locale'

app/controllers/application_controller.rb:481:in `set_locale'

lib/gitlab/error_tracking.rb:48:in `with_context'

app/controllers/application_controller.rb:546:in `sentry_context'

app/controllers/application_controller.rb:474:in `block in set_current_context'

lib/gitlab/application_context.rb:52:in `block in use'

lib/gitlab/application_context.rb:52:in `use'

lib/gitlab/application_context.rb:20:in `with_context'

app/controllers/application_controller.rb:467:in `set_current_context'

lib/gitlab/middleware/rails_queue_duration.rb:29:in `call'

lib/gitlab/metrics/rack_middleware.rb:17:in `block in call'

lib/gitlab/metrics/transaction.rb:56:in `run'

lib/gitlab/metrics/rack_middleware.rb:17:in `call'

lib/gitlab/request_profiler/middleware.rb:17:in `call'

lib/gitlab/middleware/go.rb:20:in `call'

lib/gitlab/etag_caching/middleware.rb:13:in `call'

lib/gitlab/middleware/multipart.rb:125:in `call'

lib/gitlab/middleware/read_only/controller.rb:51:in `call'

lib/gitlab/middleware/read_only.rb:18:in `call'

lib/gitlab/middleware/same_site_cookies.rb:27:in `call'

lib/gitlab/middleware/basic_health_check.rb:25:in `call'

lib/gitlab/middleware/request_context.rb:23:in `call'

config/initializers/fix_local_cache_middleware.rb:9:in `call'

lib/gitlab/metrics/requests_rack_middleware.rb:60:in `call'

lib/gitlab/middleware/release_env.rb:12:in `call'

Completed 500 Internal Server Error in 95ms (Views: 0.2ms | ActiveRecord: 59.0ms | Elasticsearch: 0.0ms | Allocations: 13258)