You need to sign in or sign up before continuing.
Consolidate creation of Alert issues / incidents
We have various ways we create an Incident issue (Incident), which at the moment are inconsitent and lead to differing results.
The ways we create issues from alerts are currently:
- Automatically via an Alert payload hitting either the
projects/alerting/notifications_controller.rb
, orprometheus/alerts_controller.rb
- Manually via the Create Issue button in the alerts page.
TODO Graph showing behaviour
Proposal:
- Consolidate the two processes at the earliest possible stage.
- Remove reliance of
Alerting::Alert
class, and it's presenterProjects::Prometheus::AlertPresenter
- Push logic into AlertManagement presenters
- Ensure test cases check to see that created issues are the same. (Potentially via shared examples).
Edited by Sean Arnold