Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 35,954
    • Issues 35,954
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1,285
    • Merge Requests 1,285
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Issues
  • #232949

Closed
Open
Opened Jul 30, 2020 by Francisco Javier López@fjsanpedro🌴Developer

Follow-up from "Add info about update_mirror_service_json.log"

In 7f637e2a we introduced the json logger update_mirror_service_json to track errors related to LFS mirroring updates.

Originally, the idea was to track also other errors of the update mirroring process in this file, nevertheless, any error fallback to the Rails.logger in RepositoryUpdateMirrorWorker.

It would be great if we could track all update mirroring errors in the same file and avoid logging them to the general Rails.logger. That way, those will be easier to track.

Basically, for this change, we will need to create the existing logger UpdateMirrorServiceJsonLogger in the RepositoryUpdateMirrorWorker and pass it to UpdateMirrorService in case it needs to log something.

Important: before implementing this change we need to make an MR to index the update_mirror_service_json file in fluentd. If we implement this before the indexing, we will lose the capacity to see these errors because they will no longer be in the general logger file.

Edited Jul 30, 2020 by Francisco Javier López
Assignee
Assign to
Backlog
Milestone
Backlog
Assign milestone
Time tracking
None
Due date
None
Reference: gitlab-org/gitlab#232949