Geo: Clean up: Remove `log_geo_deleted_event` stubs
The following discussion from !36594 (merged) should be addressed:
-
@mkozono started a discussion: Actually this issue is closed, but we don't need this old event method for SSF blobs since we replicate delete events, which would be triggered without needing this hook https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/uploaders/ee/object_storage.rb
The existence of this concern and its method are causing unnecessary maintenance work: !50740 (diffs, comment 488385416)
Implementation Guide
-
Add the event directly to Uploaders that still need it => No longer needed after the migration to Geo Self-Service Framework was finished. All of these methods are a no-op. -
Remove the concern https://gitlab.com/gitlab-org/gitlab/-/blob/v13.8.0-ee/ee/app/uploaders/ee/object_storage.rb -
Remove alias_method :upload, :model: !50740 (diffs, comment 488385416) -
Remove any other unnecessary downstream changes due to this tech debt -
Search for https://gitlab.com/gitlab-org/gitlab/-/issues/232917in the codebase, and remove/address each instance -
Search for log_geo_deleted_eventin the codebase, and remove/address each instance
Edited by Michael Kozono