Broken design links

Summary

Paste full link on comment/issue not parsed correctly.
Exemple:

  1. https://gitlab.instance/group/project/-/issues/1/designs/complex_image_name_ÉÀéàæœ.png self-managed found:gitlab.com
  2. https://gitlab.instance/group/project/-/issues/1/designs/simple_image.png self-managed

Steps to reproduce

  • Add design to an issue on self-managed
  • Copy link to comment/post
  • link is not valid
    1. file extension is removed, making link invalid
    2. or link not recognized

Example Project

Exemple issue: ax10336/test-design#1

What is the current bug behavior?

see ax10336/test-design#1 and image

What is the expected correct behavior?

A working link 😉

Relevant logs and/or screenshots

(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's tough to read otherwise.)

Output of checks

  • This bug happens partially on GitLab.com
  • Found on docker version of gitlab (see first comment)
  • Found on 3 instances with 13.1.x and 13.2.x all using apache 2.4 as front server

Results of GitLab environment info

Expand for output related to GitLab environment info 
~# gitlab-rake gitlab:env:info

System information
System:         Debian 9.13
Current User:   g
Using RVM:      no
Ruby Version:   2.6.6p146
Gem Version:    2.7.10
Bundler Version:1.17.3
Rake Version:   12.3.3
Redis Version:  5.0.9
Git Version:    2.27.0
Sidekiq Version:5.2.9
Go Version:     unknown

GitLab information
Version:        13.2.1
Revision:       b55baf593e6
Directory:      /opt/gitlab/embedded/service/gitlab-rails
DB Adapter:     PostgreSQL
DB Version:     11.8
URL:            https://xxxxxxxxxxx
HTTP Clone URL: https://xxxxxxxxxxx/some-group/some-project.git
SSH Clone URL:  g@xxxxxxxxx:some-group/some-project.git
Using LDAP:     no
Using Omniauth: no

GitLab Shell
Version:        13.3.0
Repository storage paths:
- default:      /home/xxxxxxxxxxx/repositories
GitLab Shell path:              /opt/gitlab/embedded/service/gitlab-shell
Git:            /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check 
~# gitlab-rake gitlab:check SANITIZE=true
Checking GitLab subtasks ...

Checking GitLab Shell ...


GitLab Shell: ... GitLab Shell version >= 13.3.0 ? ... OK (13.3.0)
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Internal API available: OK
Redis available via internal API: OK
gitlab-shell self-check successful


Checking GitLab Shell ... Finished


Checking Gitaly ...


Gitaly: ... default ... OK


Checking Gitaly ... Finished


Checking Sidekiq ...


Sidekiq: ... Running? ... yes
Number of Sidekiq processes ... 1


Checking Sidekiq ... Finished


Checking Incoming Email ...


Incoming Email: ... Reply by email is disabled in config/gitlab.yml


Checking Incoming Email ... Finished


Checking LDAP ...


LDAP: ... LDAP is disabled in config/gitlab.yml


Checking LDAP ... Finished


Checking GitLab App ...


Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
1/1 ... yes
4/3 ... yes
4/4 ... yes
3/5 ... yes
5/12 ... yes
5/13 ... yes
11/14 ... yes
4/15 ... yes
6/16 ... yes
6/17 ... yes
4/19 ... yes
6/20 ... yes
3/21 ... yes
7/23 ... yes
11/29 ... yes
10/32 ... yes
10/33 ... yes
10/34 ... yes
10/35 ... yes
4/37 ... yes
11/47 ... yes
11/48 ... yes
11/49 ... yes
5/50 ... yes
20/51 ... yes
3/52 ... yes
12/53 ... yes
13/54 ... yes
13/55 ... yes
5/56 ... yes
13/57 ... yes
4/58 ... yes
5/59 ... yes
11/60 ... yes
4/61 ... yes
2/62 ... yes
2/63 ... yes
2/64 ... yes
13/67 ... yes
14/68 ... yes
4/69 ... yes
5/70 ... yes
14/71 ... yes
14/72 ... yes
13/73 ... yes
14/75 ... yes
20/76 ... yes
7/77 ... yes
7/78 ... yes
11/79 ... yes
13/80 ... yes
3/81 ... yes
19/82 ... yes
3/83 ... yes
19/84 ... yes
3/85 ... yes
Redis version >= 4.0.0? ... yes
Ruby version >= 2.5.3 ? ... yes (2.6.6)
Git version >= 2.22.0 ? ... yes (2.27.0)
Git user has default SSH configuration? ... yes
Active users: ... 2
Is authorized keys file accessible? ... yes
GitLab configured to store new projects in hashed storage? ... yes
All projects are in hashed storage? ... yes


Checking GitLab App ... Finished


Checking GitLab subtasks ... Finished
Edited by Æx