Skip to content

Expose Note against Timelog from API

!35916 (merged) introduced an optional note_id field into a timelog. If the timelog was created via quick action with no other text, e.g.

/spend 1h

there is no note_id since there is no note created. However, if the timelog was created in a note with text, such as

This turned out to be easy so it didn't take as much time as I thought.
/spend 1h

the new note's note_id is persisted in the timelog.

Do we need to add this new bit of information to any views? 🤔

edit: It needs to be added to the API


The following discussion from !35916 (merged) should be addressed:

  • @engwan started a discussion: (+3 comments)

    The tests passed 🎉

    @cablett can you do maintainer review for this?

    The changes here were suggested by me so it would be nice for someone else to take a look. It's not ideal but I think it's the cleanest way to do it without redesigning our quick action DSL / service to have a reference to the persisted object? 🤔

Edited by Lee Tickett