Edit an issue/mr without change triggers a webhook when nothing is change

Summary

Editing an Issue or MR triggers a WebHook even when there isn't any real changes.

Steps to reproduce

  • Create an issue with the title "foo"
  • Click on "Edit title and description"
  • Click on "Save changes"
  • See that a webhook is generate

What is the current bug behavior?

A webhook is triggered even nothing was changed

What is the expected correct behavior?

No webhook triggered when nothing is change

Results of GitLab environment info

Expand for output related to GitLab environment info

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:env:info)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production)

Results of GitLab application Check

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:check SANITIZE=true)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)

(we will only investigate if the tests are passing)

Possible fixes

Compare the previous issue/mr with the current and trigger webhook only if there is a change.

Edited Jul 05, 2018 by Antoine Huret
Assignee Loading
Time tracking Loading