should this also have a filter by current_node projects or groups as well ?
Good question. I suppose the query worked by coincidence; i.e. all of those uploads did not have any relationship to Namespace or Project. Unfortunately it looks like uploads with model_typeDesignManagement::Action (which are a relatively new thing) currently fall into this case, but should not, since that model belongs_to :design which belongs_to :project. Since I would like to make no change in behavior in this MR, I'll open a follow up for this.
0 of 2 checklist items completed
· Edited by
Alex Ives
Designs
Child items
...
Show closed items
Linked items
0
Link issues together to show that they're related or that one is blocking others.
Learn more.
@mkozono based on the conversation it sounds like we're syncing extra data and ignoring selective sync settings. If so that's probably not great. In the past, syncing things outside of selective sync has been considered a security problem, based on that it seems like we should probably priortize this. It feels not that bad, but it also seems like we have not mitigation for it. From an experience perspective this may be a severity2, if so we should probably make sure we fix it.
@alexives I agree with your assessment. If the design thumbnails outside selective sync are discoverable then it probably is a severity1 or severity2. If they cannot, then severity3 might be ok.
@alexives Sorry, I was thinking about it wrong. I was thinking "are users who are not authorized by policies to see these designs able to see them?". But you're right, historically we have accommodated usage of selective sync as an independent way to block unauthorized access. Which is kind of annoying. So I've opened #322475 (closed) for discussion.
That doesn't need to block this though-- let's continue as usual here. I'll remove needs investigation. Thanks!
Given that we concluded that selective sync is not (was never) intended for access control in #322475 (closed) and we intend to document that further in !54931 (merged),
I am bumping this down to severity3 since design thumbnails have low impact on other usages of selective sync such as cost savings or progressive rollout of Geo.
This groupgeo bug has at most 25% of the SLO duration remaining and is ~"approaching-SLO" breach. Please consider taking action before this becomes a ~"missed-SLO" in 14 days (2021-04-20).
Contributions like this are vital to help make GitLab a better product.
We would be grateful for your help in verifying whether your bug report requires further attention from the team. If you think this bug still exists, and is reproducible with the latest stable version of GitLab, please comment on this issue.
This issue has been inactive for more than 12 months now and based on the policy for inactive bugs, will be closed in 7 days.
Thanks for your contributions to make GitLab better!
Contributions like this are vital to help make GitLab a better product.
We would be grateful for your help in verifying whether your bug report requires further attention from the team. If you think this bug still exists, and is reproducible with the latest stable version of GitLab, please comment on this issue.
This issue has been inactive for more than 12 months now and based on the policy for inactive bugs, will be closed in 7 days.
Thanks for your contributions to make GitLab better!
I am lowering the priority of this issue to priority3 . While this is an important fix, we have not had any customers complain about the current functionality and it does not pose a data loss risk.
As a part of our refinement process, we are doing a clean up where we are closing issues older than 5 years. Please reopen this issue if you are still seeing this issue or would like further action on this issue.