Deleted Projects not being properly deleted

Summary

Deleting a project causes the project not to be entirely deleted.

Steps to reproduce

  • Create project
  • Set for adjourned deletion
  • Wait for adjourned deletion to occur
  • Attempt to load project - it will load

Example Project

(If possible, please create an example project here on GitLab.com that exhibits the problematic behavior, and link to it here in the bug report)

(If you are using an older version of GitLab, this will also determine whether the bug is fixed in a more recent version)

What is the current bug behavior?

Project still loads after apparent deletion but with no data:

image

What is the expected correct behavior?

Project does not load after deletion.

Relevant logs and/or screenshots

https://log.gprd.gitlab.net/app/kibana#/discover/doc/AW5F1e45qthdGjPJueGO/pubsub-rails-inf-gprd-003219?id=c6gvcnMBczpL6wEeiwOb

Output of checks

(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)

Possible fixes

When deletion is attempted, SQL errors are raised that prevent the full deletion sequence. Example:

[ gprd ] production> p.delete_error 
=> "PG::QueryCanceled: ERROR:  canceling statement due to statement timeout\nCONTEXT:  SQL statement \"DELETE FROM ONLY \"public\".\"ci_pipelines_config\" WHERE $1 OPERATOR(pg_catalog.=) \"pipeline_id\"\"\n"
Edited by Dan Jensen