Migrate deprecatedModal to GlModal in app/assets/javascripts/boards/components/board_form.vue
app/assets/javascripts/boards/components/board_form.vue
Instructions
- Replace each instance of deprecatedModal with GlModal.
-
Update spec in
spec/frontend/boards/components/board_form_spec.js
- Take before/after screenshots of each button in the file, and upload them in the Merge Request description.
- Request review from a designer within your stage group. If you are outside of a stage group, ping a UX foundations member.
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Taurie Davis added to epic &3938 (closed)
added to epic &3938 (closed)
- Taurie Davis added component:modal pajamasintegrate typemaintenance labels
added component:modal pajamasintegrate typemaintenance labels
- Maintainer
@tauriedavis FYI the deprecated modal is still used in at least one end-to-end (QA) test via this page object using this selector.
I believe that's the last place it's used in the e2e tests (after !41029 (merged))
It would be great if that page object could be updated at the same time. Anyone in Quality can help with that if needed, myself included
😀 1 Collapse replies - Author Developer
cc @jareko (he is leading the modal work)
- Contributor
Thanks @mlapierre I'll be sure to ping you for a code review
👍 1
- Jarek Ostrowski assigned to @jareko
assigned to @jareko
- Jarek Ostrowski mentioned in merge request !46172 (closed)
mentioned in merge request !46172 (closed)
- Contributor
@sstern
👋 I tried migrating this modal togl-modal
but realized quickly this is going to need a bit of refactoring. Are you or someone else in groupproject management frontend able to take this on as part of our Pajamas migration efforts? Collapse replies - Contributor
cc @donaldcook for scheduling
- Developer
- Contributor
@donaldcook Awesome, appreciate it!
- Contributor
@donaldcook Assigning you to show this issue is accounted for. Feel free to reassign to appropriate DRI
👍 . - Developer
- Jarek Ostrowski unassigned @jareko
unassigned @jareko
- Scott Stern added workflowscheduling label
added workflowscheduling label
- Annabel Dunstone Gray assigned to @annabeldunstone
assigned to @annabeldunstone
- Maintainer
Assigned myself without reading the above
😅 1 - Annabel Dunstone Gray unassigned @annabeldunstone
unassigned @annabeldunstone
- Donald Cook changed milestone to %13.7
changed milestone to %13.7
- Donald Cook added devopsplan frontend groupproduct planning labels
added devopsplan frontend groupproduct planning labels
- 🤖 GitLab Bot 🤖 added [deprecated] Accepting merge requests label
added [deprecated] Accepting merge requests label
- 🤖 GitLab Bot 🤖 added sectiondev label
added sectiondev label
- Jarek Ostrowski assigned to @donaldcook
assigned to @donaldcook
- Donald Cook added workflowready for development label and removed workflowscheduling label
added workflowready for development label and removed workflowscheduling label
- Donald Cook set weight to 2
set weight to 2
- Donald Cook unassigned @donaldcook
unassigned @donaldcook
- Florie Guibert assigned to @fguibert
assigned to @fguibert
- Florie Guibert added workflowin dev label and removed workflowready for development label
added workflowin dev label and removed workflowready for development label
- Florie Guibert mentioned in merge request !48647 (merged)
mentioned in merge request !48647 (merged)
- 🤖 GitLab Bot 🤖 removed [deprecated] Accepting merge requests label
removed [deprecated] Accepting merge requests label
- Florie Guibert added workflowin review label and removed workflowin dev label
added workflowin review label and removed workflowin dev label
- Author Developer
@fguibert It looks like we may be able to close this issue since the MR is merged. Can you confirm?
Collapse replies - Maintainer
@tauriedavis Absolutely! Closing.
- Florie Guibert closed
closed
- Florie Guibert added workflowproduction label and removed workflowin review label
added workflowproduction label and removed workflowin review label