Enable ci_pipeline_status_omit_commit_sha_in_cache_key by default
What
Remove the :ci_pipeline_status_omit_commit_sha_in_cache_key
feature flag [ see !33712 (merged) ]
NB: This is reliant on the dashboard_pipeline_status
as the only views that uses these are dashboard views (e.g. https://staging.gitlab.com/?personal=true&sort=latest_activity_desc)
Owners
- Team: Configure
- Most appropriate slack channel to reach out to:
#s_verify
- Best individual to reach out to: @tkuah
Expectations
What are we expecting to happen?
Reduction of Gitaly calls in dashboard pages. E.g. https://gitlab.com/, https://gitlab.com/dashboard/projects/starred
What might happen if this goes wrong?
Pipeline status is not displayed for project(s) on dashboard page
NOTE: I found a separate issue in #232337. I think it's OK to continue, given that parent-child pipelines are lower usage and won't probably appear on the dashboard page. The cache status for projects with parent-child pipelines should heal on the next pipeline run
Mitigation. The quickest way is to actually hide the pipeline status again by disabling the dashboard_pipeline_status
FF
What can we monitor to detect problems with this?
Beta groups/projects
If applicable, any groups/projects that are happy to have this feature turned on early. Some organizations may wish to test big changes they are interested in with a small subset of users ahead of time for example.
-
gitlab-org/gitlab
project -
gitlab-org/gitlab-development-kit
project
Roll Out Steps
-
Enable on staging -
Test on staging -
Ensure that documentation has been updated -
Enable on GitLab.com for individual groups/projects listed above and verify behaviour -
Coordinate a time to enable the flag with #production
and#g_delivery
on slack. -
Announce on the issue an estimated time this will be enabled on GitLab.com -
Enable on GitLab.com by running chatops command in #production
-
Cross post chatops slack command to #support_gitlab-com
(more guidance when this is necessary in the dev docs) and in your team channel -
Announce on the issue that the flag has been enabled -
Remove feature flag and add changelog entry -
After the flag removal is deployed, clean up the feature flag by running chatops command in #production
channel