Skip to content

deleting a project fails with "no implicit conversion of nil into String "

Summary

Deleting any project fails with this message

This project was scheduled for deletion, but failed with the following message: no implicit conversion of nil into String

See https://git.bubu1.eu/Bubu/test

Steps to reproduce

  • Create a project
  • Try to delete project
  • Go to project page, see the banner about failed deletion

Example Project

https://git.bubu1.eu/Bubu/test

What is the current bug behavior?

Project failed to delete

Looks like this:

image

What is the expected correct behavior?

Project deleted

Relevant logs and/or screenshots

I see the delete request in the production_json.log:

{
  "method": "DELETE",
  "path": "/Bubu/test",
  "format": "html",
  "controller": "ProjectsController",
  "action": "destroy",
  "status": 302,
  "location": "https://git.bubu1.eu/dashboard/projects",
  "time": "2020-07-13T22:38:04.659Z",
  "params": [
    {
      "key": "utf8",
      "value": "✓"
    },
    {
      "key": "_method",
      "value": "delete"
    },
    {
      "key": "authenticity_token",
      "value": "[FILTERED]"
    },
    {
      "key": "namespace_id",
      "value": "Bubu"
    },
    {
      "key": "id",
      "value": "test"
    }
  ],
  "remote_ip": "82.119.23.254",
  "user_id": 2,
  "username": "Bubu",
  "ua": "Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0",
  "correlation_id": "El9cR7aprFa",
  "meta.user": "Bubu",
  "meta.project": "Bubu/test",
  "meta.root_namespace": "Bubu",
  "meta.caller_id": "ProjectsController#destroy",
  "redis_calls": 4,
  "redis_duration_s": 0.001345,
  "redis_read_bytes": 358,
  "redis_write_bytes": 2448,
  "redis_queues_calls": 3,
  "redis_queues_duration_s": 0.000923,
  "redis_queues_read_bytes": 80,
  "redis_queues_write_bytes": 1857,
  "redis_shared_state_calls": 1,
  "redis_shared_state_duration_s": 0.000422,
  "redis_shared_state_read_bytes": 278,
  "redis_shared_state_write_bytes": 591,
  "cpu_s": 0.05,
  "db_duration_s": 0.02143,
  "view_duration_s": 0,
  "duration_s": 0.05381
}

In application_json.log I get the following:

{"severity":"INFO","time":"2020-07-13T22:38:04.657Z","correlation_id":"El9cR7aprFa","message":"User 2 scheduled destruction of project Bubu/test with job ID 43bd7a7b9e843ca0099be86c"}
{"severity":"ERROR","time":"2020-07-13T22:38:04.750Z","correlation_id":"El9cR7aprFa","message":"Deletion failed on Bubu/test with the following message: no implicit conversion of nil into String"}

The sidekiq log contains the following:

{
  "severity": "INFO",
  "time": "2020-07-13T23:19:59.220Z",
  "class": "ProjectDestroyWorker",
  "retry": 3,
  "queue": "project_destroy",
  "backtrace": 5,
  "jid": "94d92efd9b794e10d06e5bb5",
  "created_at": "2020-07-13T23:19:59.109Z",
  "meta.user": "Bubu",
  "meta.project": "Bubu/test",
  "meta.root_namespace": "Bubu",
  "meta.caller_id": "ProjectsController#destroy",
  "correlation_id": "kyrTd0ZDrj",
  "enqueued_at": "2020-07-13T23:19:59.111Z",
  "pid": 624040,
  "message": "ProjectDestroyWorker JID-94d92efd9b794e10d06e5bb5: done: 0.106332 sec",
  "job_status": "done",
  "scheduling_latency_s": 0.00205,
  "redis_calls": 4,
  "redis_duration_s": 0.001451,
  "redis_read_bytes": 125,
  "redis_write_bytes": 273,
  "redis_cache_calls": 2,
  "redis_cache_duration_s": 0.000707,
  "redis_cache_read_bytes": 123,
  "redis_cache_write_bytes": 89,
  "redis_queues_calls": 2,
  "redis_queues_duration_s": 0.000744,
  "redis_queues_read_bytes": 2,
  "redis_queues_write_bytes": 184,
  "duration_s": 0.106332,
  "cpu_s": 0.054601,
  "completed_at": "2020-07-13T23:19:59.220Z",
  "db_duration_s": 0.044762
}

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info 
System information
System:		
Current User:	gitlab
Using RVM:	no
Ruby Version:	2.7.1p83
Gem Version:	3.1.3
Bundler Version:2.1.4
Rake Version:	12.3.3
Redis Version:	6.0.5
Git Version:	2.27.0
Sidekiq Version:5.2.7
Go Version:	go1.14.4 linux/amd64

GitLab information
Version:	13.1.4
Revision:	18c5ab32b73
Directory:	/usr/share/webapps/gitlab
DB Adapter:	PostgreSQL
DB Version:	12.3
URL:		https://git.bubu1.eu
HTTP Clone URL:	https://git.bubu1.eu/some-group/some-project.git
SSH Clone URL:	gitlab@git.bubu1.eu:some-group/some-project.git
Using LDAP:	no
Using Omniauth:	yes
Omniauth Providers: github, gitlab

GitLab Shell
Version:	13.3.0
Repository storage paths:
- default: 	/var/lib/gitlab/repositories
GitLab Shell path:		/usr/share/webapps/gitlab-shell
Git:		/usr/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check 
Checking GitLab subtasks ...

Checking GitLab Shell ...


GitLab Shell: ... GitLab Shell version >= 13.3.0 ? ... OK (13.3.0)
Running /usr/share/webapps/gitlab-shell/bin/check
Internal API available: OK
Redis available via internal API: OK
gitlab-shell self-check successful


Checking GitLab Shell ... Finished


Checking Gitaly ...


Gitaly: ... default ... OK


Checking Gitaly ... Finished


Checking Sidekiq ...


Sidekiq: ... Running? ... yes
Number of Sidekiq processes ... 1


Checking Sidekiq ... Finished


Checking Incoming Email ...


Incoming Email: ... Reply by email is disabled in config/gitlab.yml


Checking Incoming Email ... Finished


Checking LDAP ...


LDAP: ... LDAP is disabled in config/gitlab.yml


Checking LDAP ... Finished


Checking GitLab App ...


Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Init script exists? ... no
Try fixing it:
Install the init script
For more information see:
doc/install/installation.md in section "Install Init Script"
Please fix the error above and rerun the checks.
Init script up-to-date? ... can't check because of previous errors
Projects have namespace: ...
2/1 ... yes
2/2 ... yes
2/3 ... yes
Redis version >= 4.0.0? ... yes
Ruby version >= 2.5.3 ? ... yes (2.7.1)
Git version >= 2.22.0 ? ... yes (2.27.0)
Git user has default SSH configuration? ... yes
Active users: ... 2
Is authorized keys file accessible? ... yes
GitLab configured to store new projects in hashed storage? ... yes
All projects are in hashed storage? ... yes


Checking GitLab App ... Finished


Checking GitLab subtasks ... Finished

Using systemd initscripts from archlinux: https://git.archlinux.org/svntogit/community.git/tree/trunk?h=packages/gitlab

Downstream Archlinux bug: https://bugs.archlinux.org/task/67269

Edited by Marcus