Follow Up on MR Refactor

Collecting all topics that need to be followed up after the merge of the new MR Page based on Vue (gitlab-foss!17011 (merged)) documenting the current state and the mitigations that need to happen.

Follow up Features

• Blob Diff Viewing (including Images will be added with gitlab-ce!19898)
• Image Commenting (xit tests in \spec\features\merge_request\user_creates_image_diff_notes_spec.rb)
• Commit Comments in MR context (2 xit tests in \spec\features\merge_request\user_sees_discussions_spec.rb)

Disabled Tests with xit

Mainly due to changed functionality inside the Vue components

Legacy Diff Notes

\spec\features\merge_request\user_posts_diff_notes_spec.rb

• when the MR only supports legacy diff notes with a new line https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21652
• when the MR only supports legacy diff notes with an old line https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21652
• when the MR only supports legacy diff notes with an unchanged line https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21652

\spec\features\merge_request\user_posts_notes_spec.rb

• deleting attachment on legacy diff note shows the delete link
• deleting attachment on legacy diff note removes the attachment div and resets the edit form

Conflicts resolved in Edit inline mode

\spec\features\merge_request\user_resolves_conflicts_spec.rb

• the conflicts are resolvable in Inline view mode https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21654

Others

\spec\features\merge_request\user_sees_notes_from_forked_project_spec.rb

• Merge request > User sees notes from forked project and user can reply to the comment

\spec\features\merge_request\user_scrolls_to_note_on_load_spec.rb

• Merge request > User scrolls to note on load and expands collapsed notes

Backend related

\spec\features\merge_request\user_sees_mini_pipeline_graph_spec.rb

• Merge request < User sees mini pipeline graph as json avoids repeated database queries

Missing Karma Tests for new components - Most probably also covered by feature tests

• spec\javascripts\diffs\components\app_spec.js
• spec\javascripts\diffs\components\changed_files_dropdown_spec.js
• spec\javascripts\diffs\components\compare_versions_dropdown_spec.js
• spec\javascripts\diffs\components\compare_versions_spec.js
• spec\javascripts\diffs\components\compare_versions_dropdown_spec.js
• spec\javascripts\diffs\components\diff_content_spec.js
• spec\javascripts\diffs\components\edit_button_spec.js
• spec\javascripts\diffs\components\hidden_files_warning_spec.js
• spec\javascripts\diffs\components\no_changes_spec.js
• spec/javascripts/diffs/components/diff_file_header_spec.js Missing tests for file actions.

Related Follow Up

• Vue diff rendering the commit and compare views - https://gitlab.com/gitlab-org/gitlab-ce/issues/44988