Skip to content

Button to add review comment on MR is unreachable using keyboard

Summary

The button used to add a comment when reviewing code on a merge request is unreachable with the keyboard

Steps to reproduce

  • Go to any merge request
  • Go to changes (/diffs)
  • Try to reach a button that adds a review comment ("Add a comment to this line") using the keyboard, i.e. pressing the <Tab> key

What is the current bug behavior?

It's unreachable, because such buttons are shown only when the related line is moused over

What is the expected correct behavior?

Buttons to add review comments should be reachable with the keyboard.

Output of checks

This bug happens on GitLab.com

Possible fixes

The button could be invisible but present, so that when it's reached by tab-nabigating, it gets visible, similar as when mouse-overing a line.