Protected branch wildcards are being pushed on mirror

Summary

Push/Mirroring to a remote repository with protected branches will not push wildcard matching branches.

Steps to reproduce

  • Create new Repository
  • New Branches: specific-branch, wildcard-1, and wildcard-2
  • Protect specific-branch and wildcard-*
  • Enable push to a remote repository. -- Set repository URL -- Only protected branches
  • Update Now

In this example, specific-branch will be pushed, but none of the wildcard branches will be mirrored. If you add another protected branch specifically for one of the other branches it will mirror correctly.

If the Only protected branches is not enabled, all branches will push successfully

Reproduced on 10.8.3/4

What is the current bug behavior?

Protected Branches based on wildcards are not mirrored

What is the expected correct behavior?

Mirror all matching protected branches

Relevant logs and/or screenshots

push

protected_branches

Internal ZD: https://gitlab.zendesk.com/agent/tickets/97447

Edited by Davin Walker