Misleading merged branch label
Problem to solve
When I visit https://gitlab.com/gitlab-org/gitlab/-/branches and search for my newly created branch it has a label of merged
.
The merged
label is misleading. The branch is "merged" because the branch HEAD is the commit we've branched from in master. If I make a commit on the branch then the label will disappear.
This is confusing and sometimes panic inducing when you forget that local work on your branch was not yet pushed to remote. It's also confusing that I can effectively "unmerge" a branch by making a commit to my branch.
Intended users
Developers.
User experience goal
Provide a more useful state of a merged
branch. Only display the merged
label when the higher level definition of a merged branch has been met, and not just meeting the lower level git tree matching SHA concept.
Proposal
Only consider display of merged
badge when:
- number of commits on branch from merge base > 0
- branch creation date < HEAD commit date
Further details
Permissions and Security
Documentation
Availability & Testing
What does success look like, and how can we measure that?
What is the type of buyer?
Is this a cross-stage feature?
Links / references
/cc @tkuah