Skip to content

Merge request approval button style inadvertently changed

Since !34207 (merged), the merge request approval button has a minor regression. Previously, if a merge request was not yet approved, and approval was required, the button would appear solid:

no approval, approval required no approval, approval not required
old-required old-not-required

However, with the change from <gl-deprecated-button> to <gl-button>, the logic to change this styling was not properly updated, so in both cases above it will look like this:

no approval, approval required (current master)
current-required

This appears to be due to the way in which this "inverted" style was applied in the older button implementation. This no longer works:

<gl-button
  :class="{ 'btn-inverted': action.inverted }"
>