Disable commenting on symlinks in an MR
Problem to solve
In the context of pursuing a solution for #33867 (closed) we realise that will involve significant overhaul of internal mechanisms that require better and deeper planning.
For the time being, it has been proposed to simply disable the commenting on these cases, to avoid breaking the experience or loss of data:
@pedroms wrote:
We would need to disable the comment icon button and display a tooltip explaining why it's disabled to set the right expectations for users. Maybe something like so:
This tooltip text could be used for both added and deleted symbolic links. For files that replace or are replaced by symbolic links, we could use this tooltip text:
Commenting on files that replace or are replaced by symbolic links is currently not supported.
User experience goal
Avoid sending users down a flow that will result in error or data loss.
Proposal
Disable comments whenever the diff file is a symlink and cannot, at this time, receive a comment.
Further details
See create-stage#12670 (comment 361521691)
Deeper refactor of the Diffs app is in discussion but not yet able to be picked up.