impossible to dowload from web UI a project directory with non-english charactes

Summary

When one tries to download project directory, with some special characters like "ł" "ę", from web UI (i.e. clicking on "Download this directory"), 404 Git Resource Not found error appears.

Steps to reproduce

Create a project which contains directory named with e.g. ISO 8859-2 (Latin-2) non-english characters. Click on "Download -> Download this directory" from web UI of this project.

Example Project

https://gitlab.com/faithlesstomas/test-dir-encoding-from-web-ui

What is the current bug behavior?

Zip (or other type) file is not downloaded, instead "404 Git Resource Not found" error appears page appears.

What is the expected correct behavior?

The zipped (or other format) file of given directory should be possible to download.

Relevant logs and/or screenshots

(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's tough to read otherwise.)

Output of checks

(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)

Results of GitLab environment info

Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Results of GitLab application Check

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:check SANITIZE=true)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)

(we will only investigate if the tests are passing)

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)

Edited by Tomasz Kazimierczak