Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 44,763
    • Issues 44,763
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,329
    • Merge requests 1,329
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #222788
Closed
Open
Issue created Jun 16, 2020 by Taylor McCaslin@tmccaslin🏳️‍🌈Developer8 of 8 checklist items completed8/8 checklist items

Bring SAST to Core - secrets

Full requirements listing in &2098 (closed)

Scope of this issue specifically

Secret Detection security plugin scanning, when Docker-in-Docker is disabled - SAST_DISABLED_DIND = true

Plan

Implementation Plan

  1. Update SAST vendored template
    • Remove check for /sast/ in features for the brakeman analyzers for the DIND-free version.
  2. Update license for the repository from EE License to MIT Expat Minor Version Bump

Test Plan

  1. Test analyzers as a core user
    • Verify Capability table from Epic
  2. Test analyzers as an ultimate user
    • Verify Capability table from Epic
    • Ensure support for downloading artifact
Edited Aug 04, 2020 by Zach Rice
Assignee
Assign to
Time tracking