Time spend note (/spend) is not triggering Note Webhook

Summary

When you add the time spent as a comment to an issue, the corresponding Note Webhook is not triggered with the data. But if the time spent is the first comment in the project and if "Test" button in webhook is used to trigger Note, this time spent info is coming through. So I assume either Notes Webhook should be triggered when /spend command is used or the "Test" button should be fixed to not send time spent event. I'm personally in favor of the former.

This happened in omnibus installation on private server. Version 10.7.3

Steps to reproduce

  • Create a new project
  • Add an issue
  • Add a comment (/spend 1h)
  • Add a Notes webhook to this project (SSL disabled in my case)
  • Trigger the webhook test. Specifically Notes test
  • You will receive Time spent note as an event in the webhook target
  • Now try to add one more comment to the issue (/spend 30m)
  • The webhook target does not get any events

What is the current bug behavior?

Webhook event for time spent notes is not triggered. But when Test button is used it is triggered

What is the expected correct behavior?

Webhook event for time spent notes should be triggered.

Results of GitLab environment info

Expand for output related to GitLab environment info 
System information
System:         Ubuntu 16.04
Current User:   git
Using RVM:      no
Ruby Version:   2.3.6p384
Gem Version:    2.6.13
Bundler Version:1.13.7
Rake Version:   12.3.0
Redis Version:  3.2.11
Git Version:    2.14.3
Sidekiq Version:5.0.5
Go Version:     unknown

GitLab information
Version:        10.7.3
Revision:       2555d6c
Directory:      /opt/gitlab/embedded/service/gitlab-rails
DB Adapter:     postgresql
URL:            http://megarac-cloud.us.megatrends.com
HTTP Clone URL: http://megarac-cloud.us.megatrends.com/some-group/some-project.git
SSH Clone URL:  git@megarac-cloud.us.megatrends.com:some-group/some-project.git
Using LDAP:     no
Using Omniauth: no


GitLab Shell
Version:        7.1.2
Repository storage paths:
  • default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check 
Checking GitLab Shell ...

GitLab Shell version >= 7.1.2 ? ... OK (7.1.2)
Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by git:root, or git:git?
default... yes
Repo paths access is drwxrws---?
default... yes
hooks directories in repos are links: ...
1/2 ... repository is empty
12/3 ... repository is empty
25/4 ... ok
25/5 ... ok
25/6 ... ok
25/7 ... ok
14/9 ... ok
14/10 ... ok
14/11 ... ok
3/12 ... ok
25/13 ... ok
26/15 ... repository is empty
...
3/304 ... repository is empty
208/305 ... ok
25/306 ... ok
187/311 ... ok
210/316 ... ok
122/317 ... ok
3/318 ... ok
224/319 ... ok
224/320 ... ok
207/322 ... ok
37/324 ... repository is empty
224/325 ... ok
209/326 ... ok
25/327 ... ok
230/328 ... ok
229/329 ... ok
64/336 ... ok
187/337 ... ok
187/338 ... ok
229/340 ... ok
235/343 ... ok
25/344 ... ok
3/345 ... ok
229/346 ... repository is empty
189/359 ... repository is empty
209/360 ... ok
3/363 ... repository is empty
249/366 ... repository is empty
3/367 ... ok
37/368 ... ok
37/369 ... ok
37/370 ... ok
246/371 ... ok
246/372 ... ok
246/374 ... ok
15/375 ... ok
37/376 ... ok
249/377 ... ok
37/378 ... ok
37/379 ... ok
25/380 ... ok
37/381 ... ok
97/382 ... repository is empty
37/383 ... ok
37/384 ... ok
37/385 ... ok
37/386 ... ok
37/387 ... ok
141/388 ... ok
37/389 ... ok
37/390 ... ok
37/391 ... ok
3/392 ... ok
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Redis available via internal API: OK


Access to /var/opt/gitlab/.ssh/authorized_keys: OK
gitlab-shell self-check successful


Checking GitLab Shell ... Finished


Checking Sidekiq ...


Running? ... yes
Number of Sidekiq processes ... 1


Checking Sidekiq ... Finished


Reply by email is disabled in config/gitlab.yml
Checking LDAP ...


LDAP is disabled in config/gitlab.yml


Checking LDAP ... Finished


Checking GitLab ...


Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... no
Try fixing it:
sudo chown -R git /var/opt/gitlab/gitlab-rails/uploads
sudo find /var/opt/gitlab/gitlab-rails/uploads -type f -exec chmod 0644 {} ;
sudo find /var/opt/gitlab/gitlab-rails/uploads -type d -not -path /var/opt/gitlab/gitlab-rails/uploads -exec chmod 0700 {} ;
For more information see:
doc/install/installation.md in section "GitLab"
Please fix the error above and rerun the checks.
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
1/2 ... yes
12/3 ... yes
25/4 ... yes
25/5 ... yes
25/6 ... yes
25/7 ... yes
14/9 ... yes
14/10 ... yes
14/11 ... yes
3/12 ... yes
25/13 ... yes
26/15 ... yes
34/16 ... yes
34/17 ... yes
37/19 ... yes
37/20 ... yes
37/21 ... yes
37/26 ... yes
37/29 ... yes
37/30 ... yes
37/31 ... yes
31/32 ... yes
25/33 ... yes
25/34 ... yes
25/35 ... yes
25/36 ... yes
37/37 ... yes
61/38 ... yes
3/40 ... yes
3/41 ... yes
3/42 ... yes
25/43 ... yes
37/44 ... yes
37/45 ... yes
37/46 ... yes
67/47 ... yes
37/49 ... yes
37/50 ... yes
25/51 ... yes
3/52 ... yes
3/53 ... yes
37/54 ... yes
3/55 ... yes
70/56 ... yes
25/57 ... yes
25/59 ... yes
30/60 ... yes
37/61 ... yes
37/63 ... yes
3/64 ... yes
37/65 ... yes
127/66 ... yes
37/67 ... yes
37/68 ... yes
37/69 ... yes
37/70 ... yes
37/72 ... yes
25/73 ... yes
96/74 ... yes
37/75 ... yes
32/76 ... yes
25/77 ... yes
37/78 ... yes
25/79 ... yes
37/80 ... yes
37/81 ... yes
37/82 ... yes
37/83 ... yes
25/85 ... yes
113/86 ... yes
25/89 ... yes
34/90 ... yes
114/91 ... yes
114/92 ... yes
42/93 ... yes
37/94 ... yes
3/95 ... yes
37/96 ... yes
25/97 ... yes
37/101 ... yes
3/102 ... yes
3/103 ... yes
37/104 ... yes
3/105 ... yes
25/106 ... yes
37/107 ... yes
3/108 ... yes
82/109 ... yes
3/110 ... yes
3/111 ... yes
3/112 ... yes
16/113 ... yes
3/115 ... yes
127/118 ... yes
37/125 ... yes
124/127 ... yes
124/128 ... yes
124/129 ... yes
124/130 ... yes
124/131 ... yes
124/132 ... yes
124/133 ... yes
124/134 ... yes
32/135 ... yes
114/136 ... yes
126/137 ... yes
126/138 ... yes
16/139 ... yes
127/141 ... yes
34/143 ... yes
127/144 ... yes
127/145 ... yes
37/146 ... yes
15/147 ... yes
15/148 ... yes
127/149 ... yes
127/150 ... yes
127/151 ... yes
37/152 ... yes
37/153 ... yes
37/154 ... yes
37/155 ... yes
37/156 ... yes
37/157 ... yes
37/158 ... yes
37/159 ... yes
64/160 ... yes
25/161 ... yes
37/162 ... yes
25/163 ... yes
25/165 ... yes
25/168 ... yes
25/169 ... yes
132/170 ... yes
30/171 ... yes
30/172 ... yes
124/173 ... yes
3/174 ... yes
138/175 ... yes
37/176 ... yes
37/177 ... yes
37/178 ... yes
96/179 ... yes
37/180 ... yes
15/184 ... yes
37/185 ... yes
15/186 ... yes
37/187 ... yes
37/188 ... yes
37/189 ... yes
129/192 ... yes
150/193 ... yes
150/194 ... yes
152/195 ... yes
153/196 ... yes
65/197 ... yes
37/198 ... yes
37/199 ... yes
37/200 ... yes
37/201 ... yes
37/202 ... yes
37/203 ... yes
150/204 ... yes
129/206 ... yes
37/207 ... yes
37/208 ... yes
96/210 ... yes
64/211 ... yes
150/212 ... yes
37/213 ... yes
37/214 ... yes
65/215 ... yes
161/216 ... yes
161/217 ... yes
15/218 ... yes
67/219 ... yes
160/220 ... yes
64/221 ... yes
37/222 ... yes
161/223 ... yes
37/224 ... yes
37/226 ... yes
161/228 ... yes
37/229 ... yes
37/230 ... yes
37/231 ... yes
37/232 ... yes
37/233 ... yes
15/234 ... yes
37/235 ... yes
37/237 ... yes
37/238 ... yes
3/239 ... yes
37/240 ... yes
37/242 ... yes
129/245 ... yes
34/246 ... yes
34/247 ... yes
37/248 ... yes
187/250 ... yes
37/251 ... yes
37/252 ... yes
34/253 ... yes
3/255 ... yes
114/256 ... yes
37/257 ... yes
114/258 ... yes
37/259 ... yes
37/260 ... yes
37/261 ... yes
37/262 ... yes
34/263 ... yes
114/264 ... yes
37/265 ... yes
37/266 ... yes
37/267 ... yes
187/268 ... yes
128/269 ... yes
37/270 ... yes
37/271 ... yes
37/272 ... yes
37/273 ... yes
37/274 ... yes
37/275 ... yes
37/276 ... yes
37/277 ... yes
37/278 ... yes
37/279 ... yes
37/280 ... yes
37/281 ... yes
122/282 ... yes
64/283 ... yes
206/284 ... yes
206/285 ... yes
206/286 ... yes
205/296 ... yes
37/301 ... yes
3/302 ... yes
37/303 ... yes
3/304 ... yes
208/305 ... yes
25/306 ... yes
187/311 ... yes
210/316 ... yes
122/317 ... yes
3/318 ... yes
224/319 ... yes
224/320 ... yes
207/322 ... yes
37/324 ... yes
224/325 ... yes
209/326 ... yes
25/327 ... yes
230/328 ... yes
229/329 ... yes
64/336 ... yes
187/337 ... yes
187/338 ... yes
229/340 ... yes
235/343 ... yes
25/344 ... yes
3/345 ... yes
229/346 ... yes
189/359 ... yes
209/360 ... yes
3/363 ... yes
249/366 ... yes
3/367 ... yes
37/368 ... yes
37/369 ... yes
37/370 ... yes
246/371 ... yes
246/372 ... yes
246/374 ... yes
15/375 ... yes
37/376 ... yes
249/377 ... yes
37/378 ... yes
37/379 ... yes
25/380 ... yes
37/381 ... yes
97/382 ... yes
37/383 ... yes
37/384 ... yes
37/385 ... yes
37/386 ... yes
37/387 ... yes
141/388 ... yes
37/389 ... yes
37/390 ... yes
37/391 ... yes
3/392 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.3.5 ? ... yes (2.3.6)
Git version >= 2.9.5 ? ... yes (2.14.3)
Git user has default SSH configuration? ... yes
Active users: ... 189


Checking GitLab ... Finished