Merge request on a merge train should not be dropped due to new comment/thread
Problem to solve
Merge request is dropped from merge train when another user opens a new thread in the MR.
Problematic scenario:
- A merge request author (@MRauthor) adds a merge request to the merge train
- While the merge request is part of the merge train, another user (@Commenter) opens a new thread
- The merge request is dropped from the merge train with a system note added to the merge train: "@MRauthor removed this merge request from the merge train because merge request is not mergeable 7 minutes ago"
Illustration of above scenario in the activities of a merge request:
Intended users
User experience goal
A new comment/thread should not result in interrupting the process once an MR has been added to merge train.
Proposal
A new thread or comment that un-resolves a thread should not drop the MR from the merge train.
Further details
Currently commenter does not have the power to remove the merge request from the merge train via the UI.
What @Commenter sees | What @MRauthor sees |
---|---|
![]() |
![]() |
Permissions and Security
Documentation
Availability & Testing
What does success look like, and how can we measure that?
What is the type of buyer?
Is this a cross-stage feature?
Links / references
Edited by Marcel van Remmerden