Skip to content
Snippets Groups Projects

Update MR approval settings to use new design

    • Closed Issue created by Robert Hunt @rob.hunt

    Problem to solve

    The current MR approval settings do not follow our Pajama's design principles and could be visually better.

    Intended users

    User experience goal

    The user should see an improved visual experience which meets our Pajama's design principles and easy to understand and use.

    Proposal

    We should change the MR Approval settings in Admin > Push Rules to use Pajama's as per the designs below. The UI changes should be shown both for when the compliance orientated MR approval settings are shown and when the normal MR approval settings are shown (one restricts by compliance framework and one does not).

    Further details

    Designs

    Figma prototype

    image

    Implementation details

    1. Create a new Vue app to be able to use GitLab UI components
    2. Implement the new UI in the Vue app and trigger the necessary form submissions
    3. Add tests

    Availability & Testing

    • Unit tests will need to be created for the Vue app
    • Unit tests may need to be updated or deleted from the HAML side
    • Integration and QA tests may need to be updated to match the new UI
    Edited by Robert Hunt

    Designs

    Child items ...

    • Activity

    Please register or sign in to reply