Reject invalid approvers when creating Approval Rules from codeowners
[W]e are filtering the users (and group members) in
ApprovalRules::ParamsFilteringServiceandApprovalRules::CreateService/ApprovalRules::UpdateService(viaApprovalRules::Updaterconcern). It seems thatMergeRequests::SyncCodeOwnerApprovalRulesdoesn't filter it that's why it's being returned in the response."Quick" fix for that is to filter the users (and group members) when syncing code owner rules. But I also think we need to refactor that filtering logic so it's reusable.