Instrument use of approval rules for self-managed instances

Problem to solve

groupsource code is working to refine and update approval rules so it works well in conjuction with the rest of the group features, however, we don't have any usage data for self-managed customers.

Proposal

Instrument the use of approval rules for self-managed by adding it to usage ping.

1. Number of project approval rules: !36316 (merged)
2. Number of eligible approvers (users only, not groups) per rule
3. Number of required approvals per rule
4. If Target branch rule option is not the default (Any branch): !36316 (merged)

Further details

We currently have this data for gitlab.com users in the analytics.gitlab_dotcom_merge_requests_xf source from the data wareshouse. We look at MRs where approvals_before_merge > 0.

Possible follow-ups

Perhaps a pairing metric, that can provide some additional insight if we don't count group members is the following:

1. Number of approval rules with only users
2. Number of approval rules with only groups
3. Number of approval rules with both users and groups

Permissions and Security

Links / references

• https://app.periscopedata.com/app/gitlab/526749/Create---Code-Review-category-dashboard