"An error occurred fetching the approval rules" on archived projects

Summary

When opening the settings of an archived project the error "An error occurred fetching the approval rules." is displayed and the approval_settings page of the project returns a 403

The issue is more cosmetic as approval rules are not relevant for achieved objects.

Steps to reproduce

  • archive a project
  • goto settings, the error will be displayed
  • url/api/v4/projects/id/approval_settings returns 403

Unarchiving the project removes the error again.

What is the expected correct behavior?

No error messages displayed in archived projects settings page as it confuses users.

Results of GitLab environment info

gitlab-ee 12.10.9 on Debian 10 using the omnibus package