Add archive design event creation to event create service
The following discussion from !33449 (merged) should be addressed:
-
@reprazent started a discussion: (+2 comments) What is archiving a design? Is this called anywhere?
@alexkalderimis:
Backlog Refinement byDocumentation needed:
No. This is an internal API, and testing is sufficient to describe usage.
Test Activity Planned:
New unit tests in event_create_service_spec.rb
. Strictly speaking, that class
won't even need to change, since it tests all valid Event::WIKI_EVENTS
, and as long
as the event model is correct, this test should not need to be edited.
Security Tests Planned:
Not necessary.
Explanation for Approach to be taken:
If this issue is limited to just tests for event_create_service.rb
and
wiki_pages/event_create_service.rb
, then I would suggest that very little
is needed here beyond verification that new actions on the Event
model are
handled correctly. But the existing tests probably won't need editing.
MR Breakdown:
One MR, possibly not even that, containing changes to the EventCreateService
classes and specs.
If this issue requires modification of the WIKI_EVENTS
model constant, then
this is likely still one MR, but with a couple of model examples
Weight Estimate:
1
@.luke:
Backlog Refinement byDocumentation needed:
Test Activity Planned: Unit tests of event creation
Security Tests Planned: n/a
Explanation for Approach to be taken: Have the current DesignManagement::DeleteDesignsService
call a new EventCreateService#destroy_designs
method.
MR Breakdown: 1-2 MRs
Weight Estimate: 2
@toupeira:
Backlog Refinement byDocumentation needed: N
Test Activity Planned: Test archival events are created correctly.
Security Tests Planned: n/a
Explanation for Approach to be taken: This is part of our change from "deleting" to "archiving"
MR Breakdown:
- 1 MR to reintroduce
EventCreateService#archive_design
from !33449 (diffs) - Possibly another MR for a background migration to rewrite all existing
destroyed
events toarchived
,
Weight Estimate: 2