Unify set_remember_me approaches for LDAP and OAuth

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

What

We currently use different approaches to do the same thing in OmniauthCallbacksController and LDAP::OmniauthCallbacksController. We should refactor these to both have their own remember_me? method but to share the same set_remember_me method if possible.

In particular, LDAP triggers Devise's Rememberable hook to run as a callback by setting user.remember_me, where as OAuth immediately calls a remember_me method that probably saves the record.

Original discussion

The following discussion from gitlab-ce!16694 should be addressed:

• @reprazent started a discussion: (+4 comments)

  How come ldap & omniauth have a separate set_remember_me, just wondering 😄.