Investigate if web search w/ Project and Group is slow
The following discussion from !31939 (merged) should be addressed:
-
@DylanGriffith started a discussion: (+1 comment) @mbergeron I noticed while doing some testing that I think this changes the "search this project" slightly. Previously you would only end up with
project_id=in the URL and not have the group_id but I think I noticed that searching within the project now sets both ids. I wonder if that was intentional. It doesn't change behaviour I would guess but I was thinking there might be a chance it changes the Elasticsearch query. Did you have a look to confirm that it doesn't negatively impact Elasticsearch query performance?
I've run some simple query on Staging and I haven't felt a noticeable difference, but only true measurements can tell us for sure.
@grantyoung I've been looking at https://gitlab.com/gitlab-org/quality/performance/blob/master/k6/tests/web/web_search_groups.js and it seems like it would be quite easy to add this case there, then use the GPT to see whether there is a difference between both searches.
I'll need to setup my GPT in order to develop this, so I might ping you for some help.