Cluster health tab does not properly handle licence check
Summary
When viewing the Kubernetes cluster health tab (Ultimate feature) with a Premium license, we show a "There was an error while retrieving metrics" error message:
While technically true as we deny access to the metrics dashboard JSON endpoint due to a license check, we should be presenting a more useful message indicating that the license is the problem instead.
I see that we are moving this feature into core eventually (#208224 (closed)) but this still affects current customers -- this "problem" was reported by a customer (Zendesk, internal only).
Steps to reproduce
- Access cluster health tab while having a premium or starter license.
Example Project
(If possible, please create an example project here on GitLab.com that exhibits the problematic behavior, and link to it here in the bug report)
(If you are using an older version of GitLab, this will also determine whether the bug is fixed in a more recent version)
What is the current bug behavior?
"There was an error while retrieving metrics" error message is shown.
What is the expected correct behavior?
"This feature is only available on an Ultimate license" error message is shown.
Relevant logs and/or screenshots
(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's tough to read otherwise.)
Output of checks
(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)