Increase limit for number of files loaded for a single diff
Problem to solve
Historically, we have set hard limits for diff size in order to ensure performance and a good UX, however, an increasing number of users come across large diff which go beyond these limits and provide a poor experience.
Intended users
User experience goal
Users should have a seamless experience no matter the size of their diff.
Proposal
Thanks to the great work done in &1816, diff load performance has increased significantly and thus increasing limits should not be as costly now.
- Increase limit for the number of files loaded on a single diff (currently 1000 - the total number of files allowed to be loaded, ie the hard limit)
- Increase total number of rendered files for a single diff (currently 50k - the number of files expanded by default, ie the soft limit)
- Increase limit for the number fo lines loaded on diff (currently 5k - total number of lines allowed to be loaded, ie the hard limit)
- Increase total number of rendered lines on diff (currently 50k - number of lines expanded by default, ie the soft limit)
Source for limit documentation: https://docs.gitlab.com/ee/development/diffs.html#diff-collection-limits
Permissions and Security
Documentation
Availability & Testing
What does success look like, and how can we measure that?
What is the type of buyer?
Is this a cross-stage feature?
Links / references
- https://gitlab.zendesk.com/agent/tickets/57833
- https://gitlab.zendesk.com/agent/tickets/80684
- https://gitlab.zendesk.com/agent/tickets/83179
- https://gitlab.zendesk.com/agent/tickets/85596
- https://gitlab.zendesk.com/agent/tickets/85969
- https://gitlab.zendesk.com/agent/tickets/89525
- https://gitlab.zendesk.com/agent/tickets/92459
- https://gitlab.zendesk.com/agent/tickets/118162
- https://gitlab.my.salesforce.com/00161000013aRjG
- https://gitlab.zendesk.com/agent/tickets/120299
- https://gitlab.my.salesforce.com/00161000004bZPD?srPos=0&srKp=001
- https://gitlab.zendesk.com/agent/tickets/137400
- https://gitlab.zendesk.com/agent/tickets/147208
Edited by Michelle Gill