Consider removing IE11 related code earlier

Currently we plan to remove the IE11 related code in %13.4. It is deprecated since %12.9 and we have received no negative feedback via #197987 (closed). Certain features e.g. (WebIDE, issues) are already broken in browser:ie11. I propose that we change our timeline and remove support in %13.1 or %13.2.

Why?

An experimental Merge Request has shown, that just by changing a few settings that are only there for IE11, we can save around 250 KB of JavaScript on every page, on average:

• !33390 (comment 351820406)
• Full Report: comparison.html

This is very significant and would align with our performance goals this quarter.

added browser:ie11 bugperformance frontend labels

@ebrinkman Do you think we could do it earlier than %13.4 and adjust our messaging?

@leipert I'm supportive. Tagging the other @gitlab-dev-section-pms to see if they have any thoughts.

I fully support the removal. My only suggestion is to add a (dismissable) banner message for IE11 users so that they understand that any weirdness they experience is not a bug or a reflection of our quality.

Some version of this (message text to be adjusted):

@hdelalic We already have such a banner is already in product since !26222 (merged)

It currently says:

From May 2020 GitLab no longer supports Internet Explorer 11.

You can provide feedback on this issue or via your usual support channels.

Please install a supported web browser for a better experience

I think we can adjust the message and remove the feedback sentence.

we can save around 250 KB of JavaScript on every page, on average

@rkuba FYI

@phikai no worries from my side. Happy to cut it out early. I think to wait for the communication until %13.2 and state it as the fist major step in the removal would be okay. I don't want to ignore the original timeline we set though if it might have a negative impact on customers.

cc @leipert

Given it's already deprecated, and the upside of removal, this sounds good to me! Maybe worth waiting to 13.2 to communicate the change though?

assigned to @leipert

@rkuba / @timzallmann / @ebrinkman / @gitlab-dev-section-pms

This is my proposal to remove the code earlier, in %13.2:

1. Post a message to the Feedback issue that we are going to remove the Support earlier, in %13.2. Main reasons: Performance and that we didn't get any feedback from users / customers otherwise. So we are iterating earlier.

2. Update the message in-product:

   From May 2020 GitLab no longer supports Internet Explorer 11.
   -You can provide feedback [on this issue](https://gitlab.com/gitlab-org/gitlab/-/issues/197987) or via your usual support channels.
   Please install a [supported web browser](https://docs.gitlab.com/ee/install/requirements.html#supported-web-browsers) for a better experience.

3. Update the docs (we also have: #214560 (closed))

4. Add an entry to the release post detailing the performance benefits, and the removal of support with 13.2

WDYT?

Sounds great! GitLab.com would also happen earlier, or? So we might get even earlier feedback on that (i highly doubt there will be any).

Thanks @leipert!

I just had a discussion with @deuley, as we have deprecated it in %12.9 with this message:

https://about.gitlab.com/releases/2020/03/22/gitlab-12-9-released/#ending-support-for-internet-explorer-11

we do not feel the need to add another entry to the %13.2 release post.

---

Since %12.9 people see a message in their self-managed instances and GitLab.com if they use IE11. It links to the aforementioned feedback issue and we haven't gotten a single reply either from a user directly or indirectly via support.

I will go and update the feedback issue, if someone feels the need to mention this in the %13.2 release post, let @deuley and I know and we can create something next week if necessary.

added to epic &3889

We already dropped browser support browser:ie11. Let's close this issue out.

closed