JS console errors on empty Alert management screen
Summary
When there are no alerts set up for a project, the alert_management_list
component throws errors in the console
Steps to reproduce
- Go to project's alert editing screen (
PROJECT_PATH/-/services/alerts/edit
) and temporarily turn all alerts off. Skip the step if there no alerts set up for the project - Go to a project's alert management screen (
PROJECT_PATH/-/alert_management
) - If there are no alerts set up for the project, the console will contain the errors, presented on the screenshot (ignore the
ERR_SSL_PROTOCOL_ERROR
ones)
Example Project
/h5bp/html5-boilerplate
in standard GDK setup.
What is the current bug behavior?
The JS errors are thrown into the console
What is the expected correct behavior?
Apparently, the errors should not be thrown and some better handling of the edge case should be introduced
Relevant logs and/or screenshots
Output of checks
(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)