Follow-up from "Add AttributesPermitter for Import attributes filtering"

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

The following discussion from !32647 (merged) should be addressed:

• @jameslopez started a discussion: (+1 comment)

  I wonder if there is a better way to organize them. I'm not sure that the readability of the file would be great if we add all the whitelisted attributes.

  This also changes the current specs - right now we are whitelisting via the spec (IIRC) so for anything we add new we'll have to add it to a list of already existing attributes that are whitelisted there. I guess the spec will not be needed anymore but we might be able to reuse the list somehow :think]

  Anyway, a couple of suggestions here would be (not limited to):

  • Keep whitelisted attributes in a different file
  • or, whitelist attributes via the model with import_whitelist: [:att1, :att2]

  Definitely a nitpick, so this is non-blocking :)