Disambiguate container in GitAccess
Summary
As more feature are ported from project to group level, we started to use the word container
a lot. However it seems its meaning gradually diverged in different part of the codebase.
- For some places, it can either be
Project
orGroup
, the hierarchy that can contain concepts. - For
GitAccess
, it can beProject
,Snippet
,Wiki
, the holder of a repository.
This has lead to buggy code, could we name/rename the usage to make it consistent?
Improvements
I am proposing to:
For case 1, keep it as is (container
's meaning is the hierarchy).
For case 2, I think we should rename those as repository_holder
.
Risks
This is a minor refactoring so should be have too much risk
Involved components
GitAccess
, UserAccess
and their subclasses.