Use constants for un-configurable sampler intervals
The following discussion from !31476 (merged) should be addressed:
-
@smcgivern started a discussion: (+4 comments) I don't think this needs a setting like the ones above, because those settings aren't exposed anywhere: !28304 (comment 338387092)
If it does need a setting, then I'd like to also take the time to do the correct steps for the existing settings
🙂
We have some of samplers to record information about the Rails application. Each of these makes its interval configurable on Settings.monitoring
: https://gitlab.com/gitlab-org/gitlab/-/blob/v12.10.0-ee/config/initializers/1_settings.rb#L722-725
However, we don't expose these settings everywhere else they should be: https://docs.gitlab.com/omnibus/settings/gitlab.yml.html#adding-a-new-setting-to-gitlabyml
This means that we're not actually exposing these as configuration settings in any way. And it's not clear if we expect people to change these anyway. So instead, we could just set the intervals as constants on the samplers, and launch them that way.