Merge Request references aren't properly parsed in log entry

Summary

We've recently moved from GitHub Enterprise to GitLab EE and have imported all our previous projects via the import function.

Since we still had some active pull requests opened that were referencing others, I had to switch from the #number syntax to !number syntax. Doing so has created the following log entry in the merge request:

However, after having the referenced merge request 6 merged, I've renamed the ticket again to indicate that its dependencies have been merged and therefore is ready to review itself, the following log entry has been created, which looks totally off:

Steps to reproduce

Haven't verified reproducing it yet, but I guess it goes like this:

• Create a first merge request
• Create another merge request and reference the previous one in its title
• Merge the first merge request
• Rename the second merge request and check the log entry created

I can imagine that it's an edge-case bug due to the way I've named the merge requests

Example Project

None necessary

What is the current bug behavior?

Some part of the underlying templating engine aren't replaced/parsed and therefore added to the log entry

What is the expected correct behavior?

The log entry should be have been changed title from [req !6][BR-57] ... to [BR-57] ....

Relevant logs and/or screenshots

See above

Results of GitLab environment info

Expand for output related to GitLab environment info

System information
System:         Ubuntu 16.04
Proxy:          no
Current User:   git
Using RVM:      no
Ruby Version:   2.3.6p384
Gem Version:    2.6.13
Bundler Version:1.13.7
Rake Version:   12.3.0
Redis Version:  3.2.11
Git Version:    2.14.3
Sidekiq Version:5.0.5
Go Version:     unknown
GitLab information
Version:        10.6.3-ee
Revision:       8b1a92e
Directory:      /opt/gitlab/embedded/service/gitlab-rails
DB Adapter:     postgresql
DB Version:     9.6.8
URL:            sorry, it's private :)
HTTP Clone URL: sorry, it's private :)
SSH Clone URL:  sorry, it's private :)
Elasticsearch:  no
Geo:            no
Using LDAP:     no
Using Omniauth: no
GitLab Shell
Version:        6.0.4
Repository storage paths:

• default: /var/data/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check

Checking GitLab Shell ...
GitLab Shell version >= 6.0.4 ? ... OK (6.0.4)
Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by git:root, or git:git?
default... yes
Repo paths access is drwxrws---?
default... yes
hooks directories in repos are links: ...
7/1 ... ok
7/2 ... ok
7/3 ... ok
7/4 ... ok
7/5 ... ok
7/6 ... ok
8/7 ... ok
8/8 ... ok
8/9 ... ok
8/10 ... ok
8/11 ... ok
8/12 ... ok
9/13 ... ok
10/14 ... ok
10/15 ... ok
10/16 ... ok
10/17 ... ok
10/18 ... ok
10/19 ... ok
10/20 ... ok
10/21 ... ok
10/22 ... ok
10/23 ... ok
10/24 ... ok
10/25 ... ok
10/26 ... ok
10/27 ... ok
10/28 ... ok
10/29 ... ok
10/30 ... ok
10/31 ... ok
10/32 ... ok
10/33 ... ok
13/34 ... ok
11/35 ... ok
11/36 ... ok
12/37 ... ok
14/38 ... ok
15/39 ... ok
15/40 ... ok
15/41 ... ok
15/42 ... ok
16/43 ... ok
17/44 ... ok
18/45 ... ok
19/46 ... ok
20/47 ... ok
21/48 ... ok
22/49 ... ok
23/50 ... ok
23/51 ... ok
24/52 ... ok
25/53 ... ok
26/54 ... ok
27/55 ... ok
28/56 ... ok
29/57 ... ok
30/58 ... ok
31/59 ... ok
32/60 ... ok
32/61 ... ok
32/62 ... ok
32/63 ... ok
32/64 ... ok
33/65 ... ok
33/66 ... ok
34/67 ... ok
35/68 ... ok
36/69 ... ok
37/70 ... ok
38/71 ... ok
39/72 ... ok
40/73 ... ok
41/74 ... ok
41/75 ... ok
41/76 ... ok
42/77 ... ok
43/78 ... ok
44/79 ... ok
45/80 ... ok
46/81 ... ok
46/82 ... ok
47/83 ... ok
48/84 ... ok
48/85 ... ok
48/86 ... ok
48/87 ... ok
48/88 ... ok
48/89 ... ok
48/90 ... ok
49/91 ... ok
50/92 ... ok
50/93 ... ok
50/94 ... ok
51/95 ... ok
52/96 ... ok
52/97 ... ok
52/98 ... ok
52/99 ... ok
52/100 ... ok
52/101 ... ok
53/102 ... ok
53/103 ... ok
53/104 ... ok
52/105 ... ok
52/106 ... ok
53/107 ... ok
53/108 ... ok
53/109 ... ok
53/110 ... ok
53/111 ... ok
54/112 ... ok
54/113 ... ok
54/114 ... ok
54/115 ... ok
54/116 ... ok
54/117 ... ok
54/118 ... ok
82/119 ... ok
55/120 ... ok
56/121 ... ok
56/122 ... ok
56/123 ... ok
56/124 ... ok
56/125 ... ok
56/126 ... ok
56/127 ... ok
56/128 ... ok
56/129 ... ok
57/130 ... ok
58/131 ... ok
58/132 ... ok
59/133 ... ok
60/134 ... ok
61/135 ... ok
61/136 ... ok
61/137 ... ok
61/138 ... ok
61/139 ... ok
62/140 ... ok
62/141 ... ok
63/142 ... ok
63/143 ... ok
63/144 ... ok
63/145 ... ok
63/146 ... ok
63/147 ... ok
63/148 ... ok
63/149 ... ok
63/150 ... ok
63/151 ... ok
63/152 ... ok
63/153 ... ok
63/154 ... ok
63/155 ... ok
63/156 ... ok
64/157 ... ok
65/158 ... ok
65/159 ... ok
65/160 ... ok
65/161 ... ok
66/162 ... ok
67/163 ... ok
68/164 ... ok
69/165 ... ok
70/166 ... ok
71/167 ... ok
72/168 ... ok
73/169 ... ok
74/170 ... ok
75/171 ... ok
76/172 ... ok
76/173 ... ok
77/174 ... ok
78/175 ... ok
78/176 ... ok
78/177 ... ok
79/178 ... ok
80/179 ... ok
81/180 ... ok
47/181 ... ok
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK
gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes
Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Reply by email is disabled in config/gitlab.yml
Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
7/1 ... yes
7/2 ... yes
7/3 ... yes
7/4 ... yes
7/5 ... yes
7/6 ... yes
8/7 ... yes
8/8 ... yes
8/9 ... yes
8/10 ... yes
8/11 ... yes
8/12 ... yes
9/13 ... yes
10/14 ... yes
10/15 ... yes
10/16 ... yes
10/17 ... yes
10/18 ... yes
10/19 ... yes
10/20 ... yes
10/21 ... yes
10/22 ... yes
10/23 ... yes
10/24 ... yes
10/25 ... yes
10/26 ... yes
10/27 ... yes
10/28 ... yes
10/29 ... yes
10/30 ... yes
10/31 ... yes
10/32 ... yes
10/33 ... yes
13/34 ... yes
11/35 ... yes
11/36 ... yes
12/37 ... yes
14/38 ... yes
15/39 ... yes
15/40 ... yes
15/41 ... yes
15/42 ... yes
16/43 ... yes
17/44 ... yes
18/45 ... yes
19/46 ... yes
20/47 ... yes
21/48 ... yes
22/49 ... yes
23/50 ... yes
23/51 ... yes
24/52 ... yes
25/53 ... yes
26/54 ... yes
27/55 ... yes
28/56 ... yes
29/57 ... yes
30/58 ... yes
31/59 ... yes
32/60 ... yes
32/61 ... yes
32/62 ... yes
32/63 ... yes
32/64 ... yes
33/65 ... yes
33/66 ... yes
34/67 ... yes
35/68 ... yes
36/69 ... yes
37/70 ... yes
38/71 ... yes
39/72 ... yes
40/73 ... yes
41/74 ... yes
41/75 ... yes
41/76 ... yes
42/77 ... yes
43/78 ... yes
44/79 ... yes
45/80 ... yes
46/81 ... yes
46/82 ... yes
47/83 ... yes
48/84 ... yes
48/85 ... yes
48/86 ... yes
48/87 ... yes
48/88 ... yes
48/89 ... yes
48/90 ... yes
49/91 ... yes
50/92 ... yes
50/93 ... yes
50/94 ... yes
51/95 ... yes
52/96 ... yes
52/97 ... yes
52/98 ... yes
52/99 ... yes
52/100 ... yes
52/101 ... yes
53/102 ... yes
53/103 ... yes
53/104 ... yes
52/105 ... yes
52/106 ... yes
53/107 ... yes
53/108 ... yes
53/109 ... yes
53/110 ... yes
53/111 ... yes
54/112 ... yes
54/113 ... yes
54/114 ... yes
54/115 ... yes
54/116 ... yes
54/117 ... yes
54/118 ... yes
82/119 ... yes
55/120 ... yes
56/121 ... yes
56/122 ... yes
56/123 ... yes
56/124 ... yes
56/125 ... yes
56/126 ... yes
56/127 ... yes
56/128 ... yes
56/129 ... yes
57/130 ... yes
58/131 ... yes
58/132 ... yes
59/133 ... yes
60/134 ... yes
61/135 ... yes
61/136 ... yes
61/137 ... yes
61/138 ... yes
61/139 ... yes
62/140 ... yes
62/141 ... yes
63/142 ... yes
63/143 ... yes
63/144 ... yes
63/145 ... yes
63/146 ... yes
63/147 ... yes
63/148 ... yes
63/149 ... yes
63/150 ... yes
63/151 ... yes
63/152 ... yes
63/153 ... yes
63/154 ... yes
63/155 ... yes
63/156 ... yes
64/157 ... yes
65/158 ... yes
65/159 ... yes
65/160 ... yes
65/161 ... yes
66/162 ... yes
67/163 ... yes
68/164 ... yes
69/165 ... yes
70/166 ... yes
71/167 ... yes
72/168 ... yes
73/169 ... yes
74/170 ... yes
75/171 ... yes
76/172 ... yes
76/173 ... yes
77/174 ... yes
78/175 ... yes
78/176 ... yes
78/177 ... yes
79/178 ... yes
80/179 ... yes
81/180 ... yes
47/181 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.3.5 ? ... yes (2.3.6)
Git version >= 2.9.5 ? ... yes (2.14.3)
Git user has default SSH configuration? ... yes
Active users: ... 5
Elasticsearch version 5.1 - 5.5? ... skipped (elasticsearch is disabled)
Checking GitLab ... Finished