Allow Danger to pick multiple reviewers for a single file
Background
The motivation behind this can be found at !31984 (comment 343614012)
The file .gitlab/ci/frontend.gitlab-ci.yml
should be reviewed both by frontend and Engineering Productivity to make sure that:
- frontend tests are properly configured and running
- Everything related to ci-build should be using consistent strategy which Engineering Productivity is more familiar with.
We touched the same idea at #211652 (closed) but ended up not doing it, but this will also help for this case so we should move forward with it.
Proposed implementation
Instead of matching from top to bottom, we can just collect everything the file can match, and expand all reviewers for that specific file.
This means the following can remain the same:
- Categories definitions
- Reviewer roulette table
The only thing we need to change is how we collect the data. However we might see surprising results given the current categories definitions, because it's not written having this in mind. We can clearly see that under the bottom there are a few falling back definitions, which may make some categories cover almost everything.
We may need to check if this is desired or it may cause confusion.