REFACTORING: Follow-up from "Update status on alert management detail view"
The following discussion from !31680 (merged) should be addressed:
-
@tristan.read started a discussion: (+1 comment) @lauraMon Nice work! A couple of suggestions:
- We should use gitlab utility classes instead of the existing ones, however since this same pattern already exists on the list view I think it could be done as a follow-up, with both instances replaced together.
- Since we are effectively duplicating this component between the list and the detail view, it would be nice to split this into a separate component file and reuse it between both views. This makes point 1. somewhat redundant. Would also recommend this as a follow-up rather than blocking this change.
Neither of these are blocking so I'm going to approve. Back to you!
Edited by Laura Montemayor