Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 44,763
    • Issues 44,763
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,329
    • Merge requests 1,329
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #217160
Closed
Open
Issue created May 08, 2020 by Christen Dybenko@cdybenkoDeveloper

Linking to designs from issue and design comments is broken - reference parser needed

Summary

When we implemented markdown for Designs, this part of the functionality was left out in the MVC but it is now critical to using and linking between designs.

Steps to reproduce

  1. Paste the full URL to a Design into an issue, MR or design comment
    Example: https://gitlab.com/gitlab-org/gitlab/-/issues/216880/designs/Scrolled_view_-_Title_+_Details.png

  2. The rendered markdown breaks:
  3. image

Example of broken Design Comment:

  • Link to live Design: #216880 (closed)Scrolled_view_-_Title_+_Details.png

What is the current bug behavior?

  • See step 3 above.

What is the expected correct behavior?

  • Should render to #216880[Screen_Shot_2020-05-08_at_11.55.35_AM.png] (comment 339179144)

Possible fixes

  • Re-implement the changes that @alexkalderimis shelved in his MR during the design markdown MVC
  • Ensure this works on descriptions/comments for all of issues, MRs and Design Comments

cc @alexkalderimis @dsatcher @mnearents @jeremy @gweaver @mikelong

Edited May 20, 2020 by Alex Kalderimis
Assignee
Assign to
Time tracking