Additional approval buttons for merge request

Problem to solve

Sometimes I'm not fully satisfied with the code and I don't want to approve specific merge request. At the same time team is under heavy pressure to deliver feature/bugfix. Approving bad code means that person takes responsibility that this piece of code was reviewed without any major concerns which puts me under two fires.

Intended users

Merge request approvers.

User experience goal

Proposal

Introduce "Acceptable" and "It works" statuses and add ability to specify their weight (e.g. 0.75 and 0.5 correspondingly).

• Acceptable - feature works but some part of the code could be done better and this can/should be changed in future.
• It works - urgent feature that must be delivered yesterday that has quick fixes, hacks and terrible code that must be changed as soon as possible but proper fix takes too much time. Some minor functionality may be broken.

This approach keeps track on quality of the code and allow to have dynamic number of required approvals.

Further details

For instance minimum required approvals is 2. This means that following combinations are possible:

1. Acceptable, Acceptable, It works => 0.75 + 0.75 + 0.5 = 2
2. Approved, It works, It works => 1 + 0.5 + 0.5 = 2
3. Acceptable, Acceptable, Approved => 0.75 + 0.75 + 1 = 2.5 and so on.

Permissions and Security

Code reviewer

Documentation

Availability & Testing

What does success look like, and how can we measure that?

What is the type of buyer?

Is this a cross-stage feature?

Links / references